You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It was originally done out of necessity of deployment: "Your function must be in a Go package at the root of your project." per docs, and we didn't want to put them in golang.org/x/build itself.
This is fine, but it does cause some overhead because we pay the costs of maintaining module versions in each module individually without much of an upside. It also means running their tests requires either cding into their directory or using a go workspace, instead of just go test ./... at the repo root. There's no particular good reason for them to stay as separate modules.
This is the tracking issue to move them into the root x/build module and deal with Cloud Function deployment specifics during the deployment step.
CC @golang/release.
The text was updated successfully, but these errors were encountered:
dmitshur
added
Builders
x/build issues (builders, bots, dashboards)
NeedsFix
The path to resolution is known, but the work has not been done.
labels
Apr 20, 2023
Our cloud function code currently lives in individual nested modules:
golang.org/x/build/cloudfns/sendwikidiff
golang.org/x/build/cloudfns/wikiwebhook
It was originally done out of necessity of deployment: "Your function must be in a Go package at the root of your project." per docs, and we didn't want to put them in golang.org/x/build itself.
This is fine, but it does cause some overhead because we pay the costs of maintaining module versions in each module individually without much of an upside. It also means running their tests requires either cding into their directory or using a go workspace, instead of just
go test ./...
at the repo root. There's no particular good reason for them to stay as separate modules.This is the tracking issue to move them into the root x/build module and deal with Cloud Function deployment specifics during the deployment step.
CC @golang/release.
The text was updated successfully, but these errors were encountered: