Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cloudfns/{sendwikidiff,wikiwebhook}: merge nested modules into root module #59741

Closed
dmitshur opened this issue Apr 20, 2023 · 2 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

Our cloud function code currently lives in individual nested modules:

It was originally done out of necessity of deployment: "Your function must be in a Go package at the root of your project." per docs, and we didn't want to put them in golang.org/x/build itself.

This is fine, but it does cause some overhead because we pay the costs of maintaining module versions in each module individually without much of an upside. It also means running their tests requires either cding into their directory or using a go workspace, instead of just go test ./... at the repo root. There's no particular good reason for them to stay as separate modules.

This is the tracking issue to move them into the root x/build module and deal with Cloud Function deployment specifics during the deployment step.

CC @golang/release.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Apr 20, 2023
@dmitshur dmitshur added this to the Unreleased milestone Apr 20, 2023
@dmitshur dmitshur self-assigned this Apr 20, 2023
@dmitshur dmitshur moved this to In Progress in Go Release Apr 20, 2023
@gopherbot
Copy link
Contributor

gopherbot commented Apr 20, 2023

Change https://go.dev/cl/486955 mentions this issue: cloudfns: merge nested modules into root module, update Go runtime

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/486956 mentions this issue: cloudfns: use go.dev instead of golang.org

gopherbot pushed a commit to golang/build that referenced this issue May 5, 2023
Both work but go.dev is newer and shorter.

For golang/go#59741.

Change-Id: I5f65d67bc997058860be77373e3a7952565acc10
Reviewed-on: https://go-review.googlesource.com/c/build/+/486956
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants