Feat: add support to custom registry. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
requested changes
Nov 14, 2025
| // e.g. via middleware.BasicAuth or exposed only on a private port. | ||
| func HandlerFor(registry *prometheus.Registry) http.Handler { | ||
| return promhttp.HandlerFor(registry, promhttp.HandlerOpts{}) | ||
| } |
Contributor
There was a problem hiding this comment.
I designed this package to be agnostic of the github.com/prometheus/client_golang/prometheus dependency. We don't necessarily need to stick with it into the future.
However, this PR would buy us into the prometheus.Registerer and prometheus.Registry types for good.
I like what you have done in this PR and it makes sense to me. However, for the above reason, I'm hesitant to merge it.
@brpaz It might be an obvious questions -- but what is the use case for having multiple prometheus registries? Are there some applications that expose two different sets of /metrics endpoints?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1