-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift: make extractor compilable with Swift 6 #17699
base: main
Are you sure you want to change the base?
Conversation
@redsun82 Thank you for working on this; greatly appreciated! |
This reverts commit 34b8b43.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial thoughts on the library and query test changes. Obviously we need to look a bit deeper into these.
swift/ql/test/library-tests/dataflow/taint/core/TaintInline.expected
Outdated
Show resolved
Hide resolved
swift/ql/test/library-tests/dataflow/taint/libraries/TaintInline.expected
Outdated
Show resolved
Hide resolved
Swift: Update models for better Swift 6 compatibility.
";Collection;true;suffix(from:);;;Argument[-1];ReturnValue;taint", | ||
";Collection;true;suffix(_:);;;Argument[-1].CollectionElement;ReturnValue.CollectionElement;value", |
Check warning
Code scanning / CodeQL
Redundant assignment. Warning
The variable row
the same value
";BidirectionalCollection;true;suffix(_:);;;Argument[-1];ReturnValue;taint", | ||
";BidirectionalCollection;true;suffix(_:);;;Argument[-1].CollectionElement;ReturnValue.CollectionElement;value", | ||
";BidirectionalCollection;true;suffix(from:);;;Argument[-1];ReturnValue;taint", | ||
";BidirectionalCollection;true;suffix(_:);;;Argument[-1].CollectionElement;ReturnValue.CollectionElement;value", |
Check warning
Code scanning / CodeQL
Redundant assignment. Warning
The variable row
the same value
Swift: More model repairs for Swift 6
WIP