-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add varlink #7062
base: main
Are you sure you want to change the base?
Add varlink #7062
Conversation
With only 51 indexed files, it's got a very long way to go to meet our usage requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you've still got remnants of a merge conflict that need cleaning up.
lib/linguist/languages.yml
Outdated
@@ -8590,6 +8590,17 @@ sed: | |||
templ: | |||
type: markup | |||
color: "#66D0DD" | |||
varlink: | |||
type: programming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really a programming language. Feels more like configuration so would fall under data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a markup language as a varlink file describes interfaces (see https://en.wikipedia.org/wiki/Interface_description_language). What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markup is for things that result in visual effects, think html. From what I've read, the only varlink files that will be committed are the interface definition files which are data by the fact they're definition files… they're defining the methods the interface implements.
https://varlink.org/ Co-Authored-By: fossdd <[email protected]>
Thanks for the review! I addressed the issues. Yeah, varlink still isn't used that much (even though it's a few years old now), but I think with systemd adopting varlink it has a pretty good starting point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cached licence file needs to be the one generated by the script/add-grammar
script you should have used to add the grammar. If you did not use this script, revert your changes and use it and then push your changes. Don't worry about keeping the history clean as we squash all commits when merging.
language_id: 396563549 | ||
wdl: | ||
type: programming | ||
color: "#42f1f4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops.
Description
https://varlink.org/
Adds varlink grammar and language
systemd started using it (see https://media.ccc.de/v/all-systems-go-2024-276-varlink-now-), so I think it's getting popular
Checklist:
#42f1f4