Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ralph #6831

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add Ralph #6831

wants to merge 5 commits into from

Conversation

tdroxler
Copy link

@tdroxler tdroxler commented May 15, 2024

Description

Ralph is the smart contract programming language for the Alephium blockchain

We also have a tree-sitter-ralph, but from what I read we can't add those ourselves to linguist.

Thx for considering my request, I'm part of alephium team, so don't hesitate if you have any question.

Cheers

Checklist:

@tdroxler tdroxler requested a review from a team as a code owner May 15, 2024 13:39
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't accept this grammar because its license is not one of these. This is stated in the CONTRIBUTING.md file.

@tdroxler
Copy link
Author

We can't accept this grammar because its license is not one of these. This is stated in the CONTRIBUTING.md file.

Let me check with the team if can change the license. I realize that the license for the code sample of wormhole is actually apache 2.0. I edited the PR description.

@lildude
Copy link
Member

lildude commented May 16, 2024

GPL samples are fine as we tokenise them, but not grammars.

@tdroxler
Copy link
Author

Ok I discussed with the team, we're all fine to change our license to apache-2.0 https://github.com/alephium/ralph-vscode/blob/main/LICENSE . it's already done

@lildude
Copy link
Member

lildude commented May 16, 2024

You need to update the submodule and add the cached license file. Replace the grammar with itself as per the docs should do the trick.

@tdroxler
Copy link
Author

You need to update the submodule and add the cached license file. Replace the grammar with itself as per the docs should do the trick.

using script/add-grammar --replace went smooth, thx a lot.

@tdroxler
Copy link
Author

@lildude do you need anything else?

@lildude
Copy link
Member

lildude commented May 27, 2024

🤔 I think the wrong content has been put in the LICENCE file of the grammar repo. It contains the content you normally put at the top of a file containing code and not the actual licence

@tdroxler
Copy link
Author

🤔 I think the wrong content has been put in the LICENCE file of the grammar repo. It contains the content you normally put at the top of a file containing code and not the actual licence

oops indeed, my bad.

It's now fixed

@lildude lildude dismissed their stale review July 10, 2024 09:31

Changes have been applied. Just pending popularity now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants