Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Charlock Holmes to 0.7.6 #4086

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

stanhu
Copy link
Contributor

@stanhu stanhu commented Mar 31, 2018

No description provided.

@lildude
Copy link
Member

lildude commented Apr 1, 2018

Is there a specific reason for this bump other than 0.7.6 was released three days ago?

@stanhu
Copy link
Contributor Author

stanhu commented Apr 1, 2018

It allows charlock_holmes to be compiled against newer icu4c versions (brianmario/charlock_holmes#126). We had some build errors on MacOS due to that.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I'm about to setup a new laptop and if this helps me in the process, I'm game. Thanks for the PR and welcome to Linguist.

@lildude lildude merged commit 718c9ef into github-linguist:master Apr 1, 2018
@stanhu
Copy link
Contributor Author

stanhu commented Apr 2, 2018

To be clear, building charlock_holmes 0.7.5 fails badly with icu4c 61.1 due to brianmario/charlock_holmes#126.

The workaround to fix this is:

gem install charlock_holmes -v '0.7.5' -- --with-cppflags=-DU_USING_ICU_NAMESPACE=1

It'd be helpful to release a new version just with the charlock_holmes package. :)

@lildude
Copy link
Member

lildude commented Apr 3, 2018

It'd be helpful to release a new version just with the charlock_holmes package. :)

It's been a while since I last made a release and plan to make one this week or early next, time dependent.

@Alhadis
Copy link
Collaborator

Alhadis commented Apr 8, 2018

The workaround to fix this is:

gem install charlock_holmes -v '0.7.5' -- --with-cppflags=-DU_USING_ICU_NAMESPACE=1

@stanhu Either that isn't working, or I'm experiencing an unrelated install issue:

EDIT 1: Scratch that, it might've been because I was running the default version of ruby shipped with macOS. Installing the latest version from Homebrew allowed me to run gem install … without hassles.

EDIT 2: Nope, still no luck. Just a different bunch of errors this time...

transliterator.cpp:101:70: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
  trans = icu::Transliterator::createInstance(icu::UnicodeString(id, id_len), UTRANS_FORWARD, p_error, status);
                                              ~~~                    ^~~~~~
transliterator.cpp:106:39: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
  u_txt = new icu::UnicodeString(txt, txt_len);
              ~~~                     ^~~~~~~
24 warnings and 3 errors generated.
make: *** [transliterator.o] Error 1

Screw this, I'll just switch computers...

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants