-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Charlock Holmes to 0.7.6 #4086
Conversation
Is there a specific reason for this bump other than 0.7.6 was released three days ago? |
It allows charlock_holmes to be compiled against newer icu4c versions (brianmario/charlock_holmes#126). We had some build errors on MacOS due to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! I'm about to setup a new laptop and if this helps me in the process, I'm game. Thanks for the PR and welcome to Linguist.
To be clear, building charlock_holmes 0.7.5 fails badly with icu4c 61.1 due to brianmario/charlock_holmes#126. The workaround to fix this is:
It'd be helpful to release a new version just with the charlock_holmes package. :) |
It's been a while since I last made a release and plan to make one this week or early next, time dependent. |
EDIT 1: EDIT 2: Nope, still no luck. Just a different bunch of errors this time...
Screw this, I'll just switch computers... |
No description provided.