Release v5.0.5 #3473
Release v5.0.5 #3473
Conversation
It's probably not wise to depend on a beta version just yet.
|
@lildude looks good overall, but we need to test the grammar updates in dotcom. I had some trouble with PHP in particular last time and had to roll back to the previous version. I've built the gem locally from this branch and opened a PR against dotcom for this. |
github-linguist.gemspec
Outdated
| @@ -16,7 +16,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency 'charlock_holmes', '~> 0.7.3' | |||
| s.add_dependency 'escape_utils', '~> 1.1.0' | |||
| s.add_dependency 'mime-types', '>= 1.19' | |||
| s.add_dependency 'rugged', '0.26.0b3' | |||
There was a problem hiding this comment.
Loosening this version is fine provided it remains compatible with dotcom (this was a problem in previous releases).
However, can you confirm your branch here is build from the latest? We actually bumped this a while ago and it looks like you were building off something old here.
There was a problem hiding this comment.
The loosening from 0.2.6.0b3 was just me reversing the bump I did in 0b9eb0c (in this PR) and instead opting for a loosening of the version. The overall change in this PR is from = 0.25.1.1 to >= 0.25.1.1.
There was a problem hiding this comment.
There's a problem with the php.tmbundle grammar update. If you cherry-pick this commit into your release branch here we can ship without that update and deal with it separately.
One of the changes in textmate/php.tmbundle@3ed4837...010cc1c leads to breakage in snippet highlighting on github.com
|
All sorted with no changes to the php.tmbundle submodule. Gonna merge and 🚢. |
* 'master' of github.com:github/linguist: Release v5.0.5 -- part Deux (github-linguist#3479) Update LICENSE Update LICENSE Copyright Date to 2017 (github-linguist#3476) Revert "Release v5.0.5" (github-linguist#3477) Release v5.0.5 (github-linguist#3473) Return early in Classifier.classify if no languages supplied (github-linguist#3471) Fix head commit for TXL grammar (github-linguist#3470)
Quite a few changes: v5.0.4...lildude:cut-release-v5.0.5
With this release I've also updated the grammars and relaxed the
ruggeddependency as we're using 0.26.0b3 on dotcom and we probably shouldn't be shipping a release of Linguist that depends on a beta version of rugged.@brandonblack as this is my first release, I'm asking for your review of this PR before I go ahead and merge, push etc, just to be safe.
Local testing with dotcom doesn't reveal any problems.