Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move codecov.yml to root directory #2991

Merged
merged 2 commits into from
May 3, 2023
Merged

test: Move codecov.yml to root directory #2991

merged 2 commits into from
May 3, 2023

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented May 3, 2023

Move the codecov.yml so Codecov uses it. The current yml that Codecov uses is bogus:

codecov:
  branch: main
  notify:
    wait_for_ci: true
  require_ci_to_pass: true
comment:
  after_n_builds: 5
  behavior: default
  layout: reach,diff,flags,files,footer
  require_changes: false
coverage:
  range:
  - 85.0
  - 100.0
ignore:
- ^Tests/SentryTests.*
parsers:
  gcov:
    branch_detection:
      conditional: true
      loop: true
      macro: false
      method: false

Furthermore, remove some default values.

#skip-changelog

Move the codecov.yml so Codecov uses it. Furthermore, remove some
default values.
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #2991 (d84cb1b) into main (3a01b17) will decrease coverage by 0.311%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #2991       +/-   ##
=============================================
- Coverage   80.538%   80.227%   -0.311%     
=============================================
  Files          265       265               
  Lines        24695     24686        -9     
  Branches     10947     10930       -17     
=============================================
- Hits         19889     19805       -84     
- Misses        4191      4322      +131     
+ Partials       615       559       -56     

see 43 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a01b17...d84cb1b. Read the comment docs.

@philipphofmann
Copy link
Member Author

#2991 (comment) is not correct. This should be fixed once we merge the yml to main.

@philipphofmann philipphofmann enabled auto-merge (squash) May 3, 2023 08:42
@philipphofmann philipphofmann merged commit b1b7d72 into main May 3, 2023
@philipphofmann philipphofmann deleted the test/codecov branch May 3, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants