Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify no debugger for SentrySDK.crash #2976

Merged
merged 1 commit into from
May 2, 2023

Conversation

philipphofmann
Copy link
Member

Clarify in code docs not to use a debugger attached when testing the SDK with SentrySDK.crash.

Came up in #2975.

#skip-changelog

Clarify in code docs to not use a debugger attached when testing the SDK with
SentrySDK.crash.
@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1265.78 ms 1276.28 ms 10.50 ms
Size 20.76 KiB 435.51 KiB 414.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7fb7afb 1202.18 ms 1219.42 ms 17.24 ms
c021422 1199.15 ms 1222.20 ms 23.05 ms
25bcc50 1209.53 ms 1224.86 ms 15.33 ms
3389927 1230.12 ms 1238.04 ms 7.92 ms
83d2d84 1211.31 ms 1227.34 ms 16.03 ms
e8b2fb4 1230.70 ms 1242.84 ms 12.14 ms
6f4d20c 1228.67 ms 1238.88 ms 10.21 ms
ea73af6 1241.69 ms 1252.96 ms 11.27 ms
326b7eb 1204.76 ms 1234.96 ms 30.20 ms
c00eafe 1253.04 ms 1256.41 ms 3.37 ms

App size

Revision Plain With Sentry Diff
7fb7afb 20.76 KiB 419.70 KiB 398.94 KiB
c021422 20.76 KiB 435.64 KiB 414.88 KiB
25bcc50 20.76 KiB 427.22 KiB 406.46 KiB
3389927 20.76 KiB 427.23 KiB 406.46 KiB
83d2d84 20.76 KiB 419.66 KiB 398.90 KiB
e8b2fb4 20.76 KiB 427.23 KiB 406.46 KiB
6f4d20c 20.76 KiB 431.71 KiB 410.95 KiB
ea73af6 20.76 KiB 425.76 KiB 404.99 KiB
326b7eb 20.76 KiB 432.31 KiB 411.55 KiB
c00eafe 20.76 KiB 432.88 KiB 412.12 KiB

@philipphofmann philipphofmann merged commit 17afc4b into main May 2, 2023
@philipphofmann philipphofmann deleted the docs/clarify-sdk-crash branch May 2, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants