Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont require profiler to start on main thread #2345

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

armcknight
Copy link
Member

Fixes #2342

@RuiAAPeres
Copy link

Approved.

@github-actions
Copy link

github-actions bot commented Oct 31, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1241.80 ms 1254.70 ms 12.90 ms
Size 20.50 KiB 343.44 KiB 322.94 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
6dc0bd1 1220.49 ms 1237.44 ms 16.95 ms
82e596a 1244.27 ms 1267.84 ms 23.57 ms
9ad4a5f 1251.53 ms 1276.46 ms 24.93 ms
3861500 1214.88 ms 1232.48 ms 17.60 ms
5025d2e 1245.14 ms 1268.58 ms 23.44 ms
4a0c282 1228.60 ms 1250.74 ms 22.14 ms
0fdf0b2 1266.27 ms 1277.90 ms 11.63 ms
64225be 1218.57 ms 1238.38 ms 19.81 ms
82e596a 1252.72 ms 1278.34 ms 25.62 ms
c929040 1254.84 ms 1278.42 ms 23.58 ms

App size

Revision Plain With Sentry Diff
6dc0bd1 20.51 KiB 333.58 KiB 313.07 KiB
82e596a 20.50 KiB 337.76 KiB 317.25 KiB
9ad4a5f 20.50 KiB 342.23 KiB 321.73 KiB
3861500 20.50 KiB 333.54 KiB 313.04 KiB
5025d2e 20.51 KiB 331.79 KiB 311.28 KiB
4a0c282 20.51 KiB 333.10 KiB 312.60 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
64225be 20.50 KiB 339.02 KiB 318.51 KiB
82e596a 20.50 KiB 337.76 KiB 317.26 KiB
c929040 20.51 KiB 333.10 KiB 312.59 KiB

Previous results on branch: armcknight/fix/profiling-on-nonmain-threads

Startup times

Revision Plain With Sentry Diff
6defbe2 1244.22 ms 1264.68 ms 20.46 ms

App size

Revision Plain With Sentry Diff
6defbe2 20.50 KiB 343.44 KiB 322.94 KiB

@armcknight
Copy link
Member Author

The failing test is SauceLabs wonkiness and not related to the code changes.

@armcknight armcknight merged commit 02eeb15 into master Oct 31, 2022
@armcknight armcknight deleted the armcknight/fix/profiling-on-nonmain-threads branch October 31, 2022 20:32
kevinrenskers added a commit that referenced this pull request Nov 1, 2022
* master:
  meta: add log source to format; update log format (#2337)
  test: disable flaky testFlush_CalledMultipleTimes_ImmediatelyReturnsFalse (#2339)
  fix: dont require profiler to start on main thread (#2345)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash SentryProfiler must be initialized on the main thread
3 participants