Set correct contention type when creating contention #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leikkisa
reviewed
Sep 24, 2019
| @@ -8,7 +8,8 @@ | |||
| contentions: [ | |||
| { description: "Billy One" }, | |||
| { description: "Billy Two" }, | |||
| { description: "Billy Three", original_contention_ids: [1, 2] } | |||
| { description: "Billy Three", original_contention_ids: [1, 2] }, | |||
| { contention_type: "HLR" } | |||
There was a problem hiding this comment.
The way it's coded, it should look more like this:
{ description: "Billy Three", original_contention_ids: [1, 2], contention_type: "HLR" }
Each of these lines represents 1 contention being created, and above when you're checking for contention_type, you're iterating through each of these. So the way it's written now, the code would interpret the last line as a new contention with a contention type, but no description.
Your test against UAT looks correct.
There was a problem hiding this comment.
Lol I had done this { description: "Billy Three", original_contention_ids: [1, 2], contention_type: "HLR" } but removed it coz I was testing something else in the spec. Fixed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects #11401
Before setting contention_type. It shows type_code: "REP"
After setting contention_type. It shows type_code: "HLR"
