[MNG-8340] Resolve parent according to the exact model location #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a plain project with one module shade + dep reduced POM would work as an IT? |
cstamas
approved these changes
Oct 29, 2024
It needs child subproject, and the shade plugin should generate the Pom in the target folder (instead of in the same directory than the Pom). |
|
Something is still not right, as this PR w/ shade in IT apache/maven-integration-testing#400 now causes NPE |
79f4756
to
a3cb0d1
Compare
# Conflicts: # impl/maven-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java
|
It seems this PR also fixes MNG-8336 |
cstamas
reviewed
Nov 13, 2024
| @@ -913,7 +913,7 @@ private Model injectLifecycleBindings( | |||
| } | |||
| project.setPluginArtifactRepositories(pluginRepositories); | |||
|
|
|||
| if (request.getRequestType() == ModelBuilderRequest.RequestType.BUILD_POM) { | |||
| if (request.getRequestType() == ModelBuilderRequest.RequestType.BUILD_PROJECT) { | |||
There was a problem hiding this comment.
One correct change from my "guesswork" 😄
cstamas
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-8340
We need to double check one last time that it works, or better, add an IT.