-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-8084] Move ModelBuilder and resolver provider to v4 api #1457
Conversation
3972cf3
to
230946d
Compare
Maybe "v3 mode" should use old stuff, and "v4 mode" should use this new stuff? As we also have "v3 scopes vs v4" scopes, and v4 scopes should not be used with v3 modes... |
How would you decide which one is used ? I'm working on rewriting the ProjectBuilder on top of the new ModelBuilder, to at least fix any regression using unit tests and integration tests. Once we have full support, we could think of having two different builders at the same time if we need to configure them differently. What kind of changes would you see ? |
By project model version? There is an important distinction: |
Right now, mvn3 scopes are not used, so we need those at all ? |
I think you are right: mvn4 scopes are "superset" of those of mvn3, plus, if you compare their ordering, they remain in same place (ordering by "width"), this is the two config "dump" output (they have main method that produces this): Maven3
Maven4
|
d3e5786
to
a72311a
Compare
24b101e
to
1104258
Compare
417807e
to
575ccce
Compare
api/maven-api-core/src/main/java/org/apache/maven/api/services/ModelBuilderResult.java
Outdated
Show resolved
Hide resolved
b603923
to
530a07c
Compare
6bdf9b4
to
6b9560b
Compare
15e332f
to
2fe22ac
Compare
2fe22ac
to
0864545
Compare
A few more changes seem to be necessary for allowing |
This provides a re-implementation of
maven-model-builder
andmaven-resolver-provider
on top of the Maven 4 api.As a consequence, apart from projects, plugins and actual build, all the v4 api and resolution should be available outside of maven with just the api,
maven-di
,maven-api-impl
and the resolver.Note that the builder and resolver provider are not yet used by maven.