[MNG-7812] Get rid of maven-shared-utils #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given maven-shared-utils is now deprecated (see MSHARED-1269), we need to remove its usage in maven. Maven core only uses the logging/message related classes from maven-shared-utils, so this PR enhance the initial v4 api with the needed interfaces and move the jansi specific code into maven-embedder
7ea1048
to
1a7c64b
Compare
cstamas
approved these changes
Jun 15, 2023
|
And shared utils was never exported by maven core, so this is just fine (dump it from core) |
elharo
reviewed
Jun 23, 2023
| * <p> | ||
| * Internally, <a href="http://fusesource.github.io/jansi/">Jansi</a> is used to render | ||
| * <a href="https://en.wikipedia.org/wiki/ANSI_escape_code#Colors">ANSI colors</a> on any platform. | ||
| * @since 3.1.0 |
There was a problem hiding this comment.
This comment should be updated.
|
|
||
| /** | ||
| * Configurable message styles. | ||
| * @since 3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/browse/MNG-7812
The PR apache/maven-shared-utils#154 propose to deprecate maven-shared-utils, as it's nearly a complete duplicate of plexus-utils / plexus-xml.
This PR brings back the few missing things (the message builder using jansi) by enhancing the v4 api with the missing bits and completely removed the maven-shared-utils dependency.