-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7714] Fixed a scenario in version sorting where sp1 is less than final #1099
Conversation
Signed-off-by: crazyhzm <[email protected]>
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Show resolved
Hide resolved
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Show resolved
Hide resolved
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: crazyhzm <[email protected]>
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Show resolved
Hide resolved
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: crazyhzm <[email protected]>
Signed-off-by: crazyhzm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I do think there's still some work to make clearer what the intention of the tests is. Possibly we also need to expand the Javadoc on ComparableVersion to indicate this class is no longer consistent with equals.
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: crazyhzm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor optional comments on javadoc, but algorithm and test wise I think this is ready. Thanks!
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Outdated
Show resolved
Hide resolved
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
Outdated
Show resolved
Hide resolved
Signed-off-by: crazyhzm <[email protected]>
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY
,where you replace
MNG-XXX
andSUMMARY
with the appropriate JIRA issue.[MNG-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.