Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example sse build error #1503

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix example sse build error #1503

merged 2 commits into from
Nov 11, 2024

Conversation

007gzs
Copy link
Collaborator

@007gzs 007gzs commented Nov 11, 2024

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Collaborator

@jizhuozhi jizhuozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.13%. Comparing base (ef31e09) to head (7f47686).
Report is 195 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1503      +/-   ##
==========================================
+ Coverage   35.91%   43.13%   +7.22%     
==========================================
  Files          69       76       +7     
  Lines       11576    12320     +744     
==========================================
+ Hits         4157     5314    +1157     
+ Misses       7104     6672     -432     
- Partials      315      334      +19     

see 69 files with indirect coverage changes

@jizhuozhi jizhuozhi merged commit 60e476d into alibaba:main Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants