Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatically generating markdown documentation for helm charts with helm-docs #1496

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

littlejiancc
Copy link
Collaborator

Ⅰ. Describe what this PR did

Automatically generating markdown documentation for helm charts with helm-docs
Add a Helm Docs pipeline to check for changes in values.yaml.

Ⅱ. Does this pull request fix one issue?

fixs #1495

Ⅲ. Why don't you add test cases (unit test/integration test)?

this is helm

Ⅳ. Describe how to verify it

helm-docs -c helm/higress -f ../core/values.yaml

Ⅴ. Special notes for reviews

@johnlanni
Copy link
Collaborator

cc @2456868764

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.52%. Comparing base (ef31e09) to head (e2310b6).
Report is 192 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
+ Coverage   35.91%   43.52%   +7.61%     
==========================================
  Files          69       76       +7     
  Lines       11576    12320     +744     
==========================================
+ Hits         4157     5362    +1205     
+ Misses       7104     6622     -482     
- Partials      315      336      +21     

see 69 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 4d1a037 into alibaba:main Nov 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants