Implement Rust Wasm Plugin Build & Publish Action #1483
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
+ Coverage 35.91% 43.44% +7.53%
==========================================
Files 69 76 +7
Lines 11576 12320 +744
==========================================
+ Hits 4157 5352 +1195
+ Misses 7104 6631 -473
- Partials 315 337 +22 |
| GO_VERSION: 1.19 | ||
| TINYGO_VERSION: 0.28.1 | ||
| ORAS_VERSION: 1.0.0 | ||
| steps: | ||
| - name: Set plugin_name and version from inputs or ref_name | ||
| - name: Set plugin_type、 plugin_name and version from inputs or ref_name |
There was a problem hiding this comment.
don't use full width character in english comments
| @@ -0,0 +1,38 @@ | |||
|
|
|||
There was a problem hiding this comment.
why do we need another Dockerfile to build?
There was a problem hiding this comment.
I referred to the builder used for packaging and publishing in the go-lang https://github.com/alibaba/higress/blob/main/plugins/wasm-go/DockerfileBuilder
There was a problem hiding this comment.
Dockerfile is enough, no need additional files
There was a problem hiding this comment.
Both Dockerfile and DockerfileBuilder are for building an artifact named plugin.wasm, but the oras is a client which aims to publish artifact to registry. It means no matter which language is, the only different is how to build an artifact but using same way to publish artifact.
In a word, I think the oras should be a independent image, but not mixed in builders.
cc @johnlanni
There was a problem hiding this comment.
builder mainly facilitates developers by eliminating the need to download corresponding versions of oras, as well as Rust build tools, etc
There was a problem hiding this comment.
For developers, devcontainer might be the best solution and I still think it should keep simple for OCI building
There was a problem hiding this comment.
Well, you're right, developers just need the Dockerfile, but it seems that the DockerfileBuilder used for building images allows the workflow for publishing wasm plugins to remain consistent with Go. From this perspective, it still makes sense
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1469
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews