Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Control gateway-api Listener with global.enableGatewayAPI in Helm #1461

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

hanxiantao
Copy link
Collaborator

Ⅰ. Describe what this PR did

1)higress-core 中 gateway-api 监听通过 helm 中 global.enableGatewayAPI 参数控制

2)默认关闭 istio 中的 gateway-api 处理

Ⅱ. Does this pull request fix one issue?

fixes #1456

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@hanxiantao hanxiantao changed the title Fix: Control gateway-api Listener with global.enableGatewayAPI in Helm fix: Control gateway-api Listener with global.enableGatewayAPI in Helm Oct 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.52%. Comparing base (ef31e09) to head (d7d4f09).
Report is 176 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/config/ingress_config.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
+ Coverage   35.91%   43.52%   +7.61%     
==========================================
  Files          69       76       +7     
  Lines       11576    12320     +744     
==========================================
+ Hits         4157     5362    +1205     
+ Misses       7104     6622     -482     
- Partials      315      336      +21     
Files with missing lines Coverage Δ
pkg/ingress/config/ingress_config.go 12.97% <0.00%> (-0.90%) ⬇️

... and 68 files with indirect coverage changes

helm/core/values.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CH3CHO CH3CHO merged commit 035e81a into alibaba:main Oct 31, 2024
8 checks passed
@hanxiantao hanxiantao deleted the support-gateway-api-close branch November 2, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants