modify log-format, then every plugin log is associated with access log #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
+ Coverage 35.91% 43.52% +7.61%
==========================================
Files 69 76 +7
Lines 11576 12320 +744
==========================================
+ Hits 4157 5362 +1205
+ Misses 7104 6622 -482
- Partials 315 336 +21 |
CH3CHO
requested changes
Oct 31, 2024
| @@ -36,7 +36,8 @@ type Log struct { | |||
| } | |||
|
|
|||
| func (l Log) log(level LogLevel, msg string) { | |||
| msg = fmt.Sprintf("[%s] %s", l.pluginName, msg) | |||
| requestID, _ := proxywasm.GetProperty([]string{"x_request_id"}) | |||
| msg = fmt.Sprintf("[%s] [%s] %s", l.pluginName, string(requestID), msg) | |||
There was a problem hiding this comment.
如果上下文里没有 request ID，日志就会输出一个空的 []，是不是不太好？
There was a problem hiding this comment.
还有如果用户走下面 57 行的 logFormat 函数输出日志，还是不会输出 request ID 的。。。
There was a problem hiding this comment.
logFormat函数改了下，然后如果request_id获取失败的话，输出个nil？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改log wrapper记录日志时的format，使得每条插件的日志能够与网关访问日志关联起来，便于排查问题