-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change http_content to Rc in HttpWrapper #1391
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
+ Coverage 35.91% 43.76% +7.84%
==========================================
Files 69 76 +7
Lines 11576 12276 +700
==========================================
+ Hits 4157 5372 +1215
+ Misses 7104 6571 -533
- Partials 315 333 +18 |
@007gzs Please fix the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @007gzs 182 | downcast_rs::impl_downcast!(HttpContextWrapper<PluginConfig> where PluginConfig: Default + DeserializeOwned + Clone+Sized);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| the trait `Sized` is not implemented for `(dyn HttpContextWrapper<PluginConfig> + 'static)`, which is required by `(dyn HttpContextWrapper<PluginConfig> + 'static): Downcast`
| required by a bound introduced by this call
|
= note: required for `(dyn HttpContextWrapper<PluginConfig> + 'static)` to implement `Downcast`
= note: this error originates in the macro `impl_downcast` which comes from the expansion of the macro `downcast_rs::impl_downcast` (in Nightly builds, run with -Z macro-backtrace for more info)
|
what's you rust version, it may run ok when rust>=1.80 https://github.com/alibaba/higress/blob/main/plugins/wasm-rust/Dockerfile |
cargo 1.80.1 (376290515 2024-07-16) |
run |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews