Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure all images are loaded to K8s before starting e2e tests #1389

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Oct 14, 2024

Ⅰ. Describe what this PR did

  1. Load pilot, gateway and curl images to the kind cluster to speed up the initialization.
  2. Add imagePullPolicy: IfNotPresent to containers using an image with latest tag, so loaded images can be used.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.93%. Comparing base (ef31e09) to head (912f10a).
Report is 139 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
+ Coverage   35.91%   43.93%   +8.02%     
==========================================
  Files          69       76       +7     
  Lines       11576     9965    -1611     
==========================================
+ Hits         4157     4378     +221     
+ Misses       7104     5253    -1851     
- Partials      315      334      +19     

see 91 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit d02c974 into alibaba:main Nov 8, 2024
12 checks passed
@CH3CHO CH3CHO deleted the feat/e2e-image-loading branch November 11, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants