Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support frontend-gray plugin's envoy.yaml file to host HTML #1343

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

Hazel0928
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1292

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/wasm-go/extensions/frontend-gray/main.go Outdated Show resolved Hide resolved
plugins/wasm-go/extensions/frontend-gray/main.go Outdated Show resolved Hide resolved
plugins/wasm-go/extensions/frontend-gray/main.go Outdated Show resolved Hide resolved
@CH3CHO
Copy link
Collaborator

CH3CHO commented Sep 25, 2024

麻烦签署一下 CLA~

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.23%. Comparing base (ef31e09) to head (c46f259).
Report is 121 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
+ Coverage   35.91%   44.23%   +8.32%     
==========================================
  Files          69       76       +7     
  Lines       11576     9895    -1681     
==========================================
+ Hits         4157     4377     +220     
+ Misses       7104     5183    -1921     
- Partials      315      335      +20     

see 91 files with indirect coverage changes

@CH3CHO CH3CHO merged commit ea99159 into alibaba:main Sep 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend-gray] 插件支持托管首页HTML文件
4 participants