Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1300

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix typos #1300

merged 1 commit into from
Sep 11, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Sep 11, 2024

Ⅰ. Describe what this PR did

Fix arugments to arguments

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.35%. Comparing base (ef31e09) to head (5eaee4d).
Report is 93 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
+ Coverage   35.91%   44.35%   +8.44%     
==========================================
  Files          69       75       +6     
  Lines       11576     9823    -1753     
==========================================
+ Hits         4157     4357     +200     
+ Misses       7104     5140    -1964     
- Partials      315      326      +11     

see 90 files with indirect coverage changes

@johnlanni johnlanni merged commit 6439b2d into alibaba:main Sep 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants