Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update README.md and support semicolon in scope #1279

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Jing-ze
Copy link
Contributor

@Jing-ze Jing-ze commented Sep 4, 2024

Ⅰ. Describe what this PR did

更新了oidc插件的 README.md,添加了令牌刷新的流程
添加了scope字段为英文分号隔开的场景

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

support semicolon in scope
@Jing-ze Jing-ze changed the title oidcupdate README.md and support semicolon in feat: update README.md and support semicolon in scope Sep 4, 2024
@Jing-ze Jing-ze changed the title feat: update README.md and support semicolon in scope fix: update README.md and support semicolon in scope Sep 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.33%. Comparing base (ef31e09) to head (6d6e5ee).
Report is 80 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
+ Coverage   35.91%   44.33%   +8.42%     
==========================================
  Files          69       75       +6     
  Lines       11576     9823    -1753     
==========================================
+ Hits         4157     4355     +198     
+ Misses       7104     5141    -1963     
- Partials      315      327      +12     

see 90 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit ea862cf into alibaba:main Sep 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants