Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log the error details in the request wrapper of Wasm go plugin #1255

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Aug 27, 2024

Ⅰ. Describe what this PR did

Log the error details in the request wrapper of Wasm go plugin.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.88%. Comparing base (ef31e09) to head (768e2fb).
Report is 64 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
+ Coverage   35.91%   43.88%   +7.97%     
==========================================
  Files          69       75       +6     
  Lines       11576     9821    -1755     
==========================================
+ Hits         4157     4310     +153     
+ Misses       7104     5186    -1918     
- Partials      315      325      +10     

see 80 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit abefb35 into alibaba:main Aug 28, 2024
12 checks passed
@CH3CHO CH3CHO deleted the fix/request-wrapper-logs branch August 29, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants