feat: add api-workflow plugin #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@lixf311 上面的CLA要签署一下 |
|
ok~ |
johnlanni
requested changes
Aug 20, 2024
johnlanni
reviewed
Aug 20, 2024
|
@lixf311 加一下我钉钉吧：chengtanzty |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
==========================================
+ Coverage 35.91% 44.18% +8.27%
==========================================
Files 69 76 +7
Lines 11576 9895 -1681
==========================================
+ Hits 4157 4372 +215
+ Misses 7104 5187 -1917
- Partials 315 336 +21 |
hanxiantao
requested changes
Aug 22, 2024
johnlanni
requested changes
Aug 22, 2024
806188c
to
25f3ea0
Compare
hanxiantao
reviewed
Sep 23, 2024
2e11e4a
to
7df922b
Compare
hanxiantao
approved these changes
Sep 23, 2024
|
LGTW |
10b299b
to
de8b786
Compare
|
@johnlanni 有时间的话，也帮忙再看下 |
johnlanni
requested changes
Oct 8, 2024
| var operators = map[string]interface{}{ | ||
| "eq": func(a, b interface{}) bool { | ||
| return fmt.Sprintf("%v", a) == fmt.Sprintf("%v", b) | ||
| }, |
There was a problem hiding this comment.
ne 是不是漏了？还是说其实不需要提供 ne，支持非操作就可以了，另外可以考虑支持一下 re-match，正则匹配
There was a problem hiding this comment.
抱歉，才看到，考虑有eq就不用ne了，删除了readme里的相关描述
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add ai-workflow plugin，the first version only supports tools.
Ⅱ. Does this pull request fix one issue?
fixes #1225
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews