Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ai-proxy custom settings #1219

Merged
merged 5 commits into from
Aug 22, 2024
Merged

feat: support ai-proxy custom settings #1219

merged 5 commits into from
Aug 22, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Aug 17, 2024 •
edited by johnlanni
Loading

fixes: #1213

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.89%. Comparing base (ef31e09) to head (41631e1).
Report is 50 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
- Coverage   35.91%   35.89%   -0.02%     
==========================================
  Files          69       69              
  Lines       11576     9500    -2076     
==========================================
- Hits         4157     3410     -747     
+ Misses       7104     5774    -1330     
- Partials      315      316       +1

see 67 files with indirect coverage changes

CH3CHO
CH3CHO approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CH3CHO
Copy link
Collaborator

CH3CHO commented Aug 22, 2024

麻烦解决一下冲突。

johnlanni
johnlanni approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 29fcd33 into alibaba:main Aug 22, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnlanni johnlanni johnlanni approved these changes

@CH3CHO CH3CHO CH3CHO approved these changes

@WeixinX WeixinX Awaiting requested review from WeixinX WeixinX is a code owner

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo Xunzhuo is a code owner

@2456868764 2456868764 Awaiting requested review from 2456868764 2456868764 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

为ai-proxy增加custom config功能
5 participants
@BiteTheDDDDt @CLAassistant @codecov-commenter @CH3CHO @johnlanni