Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace regexp #1169

Merged
merged 1 commit into from
Jul 31, 2024
Merged

replace regexp #1169

merged 1 commit into from
Jul 31, 2024

Conversation

johnlanni
Copy link
Collaborator

@johnlanni johnlanni commented Jul 31, 2024

Ⅰ. Describe what this PR did

known issue: #674

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.03%. Comparing base (ef31e09) to head (157cb7a).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
+ Coverage   35.91%   36.03%   +0.12%     
==========================================
  Files          69       69              
  Lines       11576     9483    -2093     
==========================================
- Hits         4157     3417     -740     
+ Misses       7104     5750    -1354     
- Partials      315      316       +1     

see 67 files with indirect coverage changes

@johnlanni johnlanni merged commit cc74c0d into alibaba:main Jul 31, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants