Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the official tinygo package to build Wasm go plugin builder #1161

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jul 29, 2024

Ⅰ. Describe what this PR did

Use the official tinygo package to build Wasm go plugin builder, since the current tinygo version we used, 0.28.1, no longer needs our customization.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.05%. Comparing base (ef31e09) to head (8fda6a0).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
+ Coverage   35.91%   36.05%   +0.14%     
==========================================
  Files          69       69              
  Lines       11576     9483    -2093     
==========================================
- Hits         4157     3419     -738     
+ Misses       7104     5749    -1355     
  Partials      315      315              

see 67 files with indirect coverage changes

@johnlanni johnlanni merged commit 210b97b into alibaba:main Jul 29, 2024
12 checks passed
@CH3CHO CH3CHO deleted the fix/use-official-tinygo branch July 29, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants