Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make higress-core and higress-gateway as the default container #1144

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jul 22, 2024

Ⅰ. Describe what this PR did

Make higress-core and higress-gateway as the default container, so it would be easier for users to run kubectl logs and kubectl exec commands.

image

image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Q: Why don't I use the kubectl.kubernetes.io/default-container mentioned here (https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/2227-kubectl-default-container/README.md)?

A: Although we get almost the same result after adding this annotation, the first line output, Defaulted container "higress-core" out of: higress-core, discovery will disappear, making users more difficult to know all the container names.

@CH3CHO CH3CHO requested a review from johnlanni July 22, 2024 14:05
@fengxsong
Copy link
Contributor

@CH3CHO
Copy link
Collaborator Author

CH3CHO commented Jul 23, 2024

I thing annotations can do that thick, ref: https://kubernetes.io/docs/reference/labels-annotations-taints/#kubectl-kubernetes-io-default-container

I'm aware of this. Please check out my explanation in "Ⅴ. Special notes for reviews" and let me know what do you think. Thanks. @fengxsong

Copy link
Collaborator

@cr7258 cr7258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🐉

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.11%. Comparing base (ef31e09) to head (5fcd1f7).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
+ Coverage   35.91%   36.11%   +0.20%     
==========================================
  Files          69       69              
  Lines       11576     9464    -2112     
==========================================
- Hits         4157     3418     -739     
+ Misses       7104     5730    -1374     
- Partials      315      316       +1     

see 67 files with indirect coverage changes

@CH3CHO CH3CHO merged commit 9a9e924 into alibaba:main Jul 24, 2024
8 checks passed
@CH3CHO CH3CHO deleted the feat/default-container branch July 24, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants