Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use "controller.name" to refer the controller service in higress-config #1108

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jul 10, 2024

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

partially fixes #1101

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 59aa3b5 into alibaba:main Jul 11, 2024
8 checks passed
@CH3CHO CH3CHO deleted the fix/helm-controller-name branch July 11, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持可以修改Helm部署模板中的controller.name/.Values.gateway.name
2 participants