New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix some bugs in build-and-push-wasm-plugin-image.yaml #1107

Merged

johnlanni merged 1 commit into alibaba:main from CH3CHO:fix/wasm-build-action

Jul 10, 2024

Collaborator

CH3CHO commented Jul 10, 2024

Ⅰ. Describe what this PR did

Use the entire plugin folder as the source for go build
Update the oras push command

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews


          fix: Fix some bugs in build-and-push-wasm-plugin-image.yaml

c18ad77

CH3CHO requested a review from johnlanni

July 10, 2024 04:09

johnlanni approved these changes

View reviewed changes

Collaborator

johnlanni left a comment

LGTM

johnlanni merged commit 7c749b8 into alibaba:main

8 checks passed

CH3CHO deleted the fix/wasm-build-action branch

July 10, 2024 05:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet