Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential use of mismatched tokens #1092

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

pepesi
Copy link
Contributor

@pepesi pepesi commented Jul 3, 2024

related issue #1082

@pepesi pepesi marked this pull request as draft July 3, 2024 14:02
@CH3CHO
Copy link
Collaborator

CH3CHO commented Jul 15, 2024

Is this ready for review now? @pepesi

@pepesi
Copy link
Contributor Author

pepesi commented Jul 15, 2024

Is this ready for review now? @pepesi

sorry,I haven't fully tested it yet

@pepesi pepesi marked this pull request as ready for review July 15, 2024 09:00
@CH3CHO
Copy link
Collaborator

CH3CHO commented Jul 15, 2024

Is this ready for review now? @pepesi

sorry,I haven't fully tested it yet

No problem. Please take your time.

CH3CHO
CH3CHO previously approved these changes Jul 16, 2024
Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@CH3CHO CH3CHO dismissed their stale review July 16, 2024 03:55

Wait for test result

@pepesi
Copy link
Contributor Author

pepesi commented Jul 19, 2024

Sorry, I am busy with other things and will handle it as soon as possible

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.23%. Comparing base (ef31e09) to head (9c6d474).
Report is 59 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   35.91%   44.23%   +8.32%     
==========================================
  Files          69       75       +6     
  Lines       11576     9821    -1755     
==========================================
+ Hits         4157     4344     +187     
+ Misses       7104     5148    -1956     
- Partials      315      329      +14     

see 80 files with indirect coverage changes

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@CH3CHO CH3CHO merged commit f5b8341 into alibaba:main Aug 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants