Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: controller has no right to watch deployment #1089

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Conversation

zhaoxuat
Copy link
Contributor

@zhaoxuat zhaoxuat commented Jul 3, 2024

Ⅰ. Describe what this PR did

fix higress-controller log error, has no no right to watch deployment

Ⅱ. Does this pull request fix one issue?

fixes #1088

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

kubectl -nhigress-system logs -f higress-controller-cc7974979-rjssd, has no any error

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

@CH3CHO
Copy link
Collaborator

CH3CHO commented Jul 8, 2024

Please provide the command you used to install Higress. AFAIK, Higress doesn't watch deployments.

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@CH3CHO CH3CHO merged commit 85219b6 into alibaba:main Jul 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants