Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OIDC wasm plugin #1049

Merged
merged 14 commits into from
Aug 27, 2024
Merged

feat: OIDC wasm plugin #1049

merged 14 commits into from
Aug 27, 2024

Conversation

Jing-ze
Copy link
Contributor

@Jing-ze Jing-ze commented Jun 20, 2024

Ⅰ. Describe what this PR did

Fork the oauth2proxy(https://github.com/oauth2-proxy/oauth2-proxy) and modify it into a wasm plugin

Ⅱ. Does this pull request fix one issue?

fixes #697.

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2024

CLA assistant check
All committers have signed the CLA.

@johnlanni
Copy link
Collaborator

@Jing-ze 把oauth2 proxy相关的代码独立出来吧啊,提交到这里:https://github.com/higress-group/oauth2-proxy

这样也能看到为了适配 wasm 场景,对 oauth2 proxy 做了哪些改动

@Jing-ze
Copy link
Contributor Author

Jing-ze commented Jun 21, 2024

@Jing-ze 把oauth2 proxy相关的代码独立出来吧啊,提交到这里:https://github.com/higress-group/oauth2-proxy

这样也能看到为了适配 wasm 场景,对 oauth2 proxy 做了哪些改动

higress-group/oauth2-proxy#1

plugins/wasm-go/extensions/oidc/README.md Outdated Show resolved Hide resolved
plugins/wasm-go/extensions/oidc/README.md Outdated Show resolved Hide resolved
plugins/wasm-go/extensions/oidc/README.md Outdated Show resolved Hide resolved
plugins/wasm-go/extensions/oidc/README.md Outdated Show resolved Hide resolved
@Jing-ze Jing-ze requested a review from johnlanni June 24, 2024 03:41
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.23%. Comparing base (ef31e09) to head (f4092cb).
Report is 60 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
+ Coverage   35.91%   44.23%   +8.32%     
==========================================
  Files          69       75       +6     
  Lines       11576     9821    -1755     
==========================================
+ Hits         4157     4344     +187     
+ Misses       7104     5148    -1956     
- Partials      315      329      +14     

see 90 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit e4a7807 into alibaba:main Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing OIDC Plugin's Security and Performance.
4 participants