-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OIDC wasm plugin #1049
feat: OIDC wasm plugin #1049
Conversation
@Jing-ze 把oauth2 proxy相关的代码独立出来吧啊,提交到这里:https://github.com/higress-group/oauth2-proxy 这样也能看到为了适配 wasm 场景,对 oauth2 proxy 做了哪些改动 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
==========================================
+ Coverage 35.91% 44.23% +8.32%
==========================================
Files 69 75 +6
Lines 11576 9821 -1755
==========================================
+ Hits 4157 4344 +187
+ Misses 7104 5148 -1956
- Partials 315 329 +14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Fork the oauth2proxy(https://github.com/oauth2-proxy/oauth2-proxy) and modify it into a wasm plugin
Ⅱ. Does this pull request fix one issue?
fixes #697.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews