Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle runner not found #3536

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Handle runner not found #3536

merged 1 commit into from
Nov 5, 2024

Conversation

ericsciple
Copy link
Collaborator

No description provided.

@ericsciple ericsciple requested a review from a team as a code owner November 3, 2024 21:09
@pje
Copy link
Member

pje commented Nov 4, 2024

So is the intention: "404s should never be retryable from the runner's perspective"?

@ericsciple
Copy link
Collaborator Author

So is the intention: "404s should never be retryable from the runner's perspective"?

Yes if the runner doesn't exist anymore, then shut down

@ericsciple ericsciple force-pushed the users/ericsciple/24-11-notfound branch from 438257b to b0b54b5 Compare November 5, 2024 01:27
@ericsciple ericsciple merged commit 2c03d74 into main Nov 5, 2024
9 checks passed
@ericsciple ericsciple deleted the users/ericsciple/24-11-notfound branch November 5, 2024 02:12
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luketomlinson luketomlinson luketomlinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsciple @pje @luketomlinson