Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tec: Make FreshRSS_Share::register public #5578

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

marienfressinaud
Copy link
Member

I don't know why the visibility of this method has changed, but it's essential to register custom shares as extensions.

Changes proposed in this pull request:

  • Change FreshRSS_Share::register method visibility back to public

How to test the feature manually:

N/A

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

I don't know why the visibility of this method has changed, but it's
essential to register custom shares as extensions.

Reference: a13a20d
@Alkarex Alkarex added this to the 1.22.0 milestone Aug 10, 2023
@Alkarex
Copy link
Member

Alkarex commented Aug 10, 2023

From #5289
It is an error. I indeed reduced the visibility of several methods to have fewer external contracts to maintain

@Alkarex Alkarex added the Bug (confirmed) 🐞 issues that are reproducable label Aug 10, 2023
@Alkarex Alkarex merged commit eb57f49 into FreshRSS:edge Aug 10, 2023
1 check passed
@marienfressinaud marienfressinaud deleted the tec/make-share-register-public branch August 10, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug (confirmed) 🐞 issues that are reproducable Extension 🔌
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants