code improvement for phpstan and humans ;) #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alkarex
requested changes
Feb 8, 2023
There was a problem hiding this comment.
Please make sure to pass at least PHPStan level 6:
$ vendor/bin/phpstan analyse --level 6 app/Models/Tag.php
Note: Using configuration file /home/alexandre/GitHub/FreshRSS/phpstan.neon.
1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ---------------------------------------------------------------------------------
Line Tag.php
------ ---------------------------------------------------------------------------------
:8 Property FreshRSS_Tag::$name has no type specified.
:9 Property FreshRSS_Tag::$attributes has no type specified.
:10 Property FreshRSS_Tag::$nbEntries has no type specified.
:11 Property FreshRSS_Tag::$nbUnread has no type specified.
:21 Method FreshRSS_Tag::_id() has parameter $value with no type specified.
:36 Method FreshRSS_Tag::attributes() has parameter $key with no type specified.
:44 Method FreshRSS_Tag::_attributes() has parameter $key with no type specified.
:44 Method FreshRSS_Tag::_attributes() has parameter $value with no type specified.
:59 Method FreshRSS_Tag::nbEntries() has no return type specified.
:67 Method FreshRSS_Tag::_nbEntries() has parameter $value with no type specified.
:82 Method FreshRSS_Tag::_nbUnread() has parameter $value with no type specified.
------ ---------------------------------------------------------------------------------
[ERROR] Found 11 errors|
Good start. Please check same comment than #5030 (comment) |
aledeg
approved these changes
Feb 8, 2023
3afadce
to
c3ad832
Compare
|
pass PHPSTAN 5 |
|
Pass PHPStan Leve6 |
c4e6900
to
7f6cfd6
Compare
|
I have made it pass PHPStan level 9 08fa965 |
Alkarex
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Pull request checklist: