Skip to content

Router middleware #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2019
Merged

Router middleware #177

merged 2 commits into from
Jul 19, 2019
+19 −10

Conversation

incerta
Copy link
Contributor

@incerta incerta commented Jul 10, 2019 •
edited
Loading

#175 Router middleware

  • Add 'connected-react-router' store middleware
  • Add ConnectedRouter provider to App

@piotrwitek
Copy link
Owner

piotrwitek commented Jul 17, 2019 •
edited
Loading

Hey @incerta
Thanks for your suggestion.
I'm trying to understand the benefits you have outlined but I fail to find one:

  1. How is that different from keeping providers in App component and just adding testStore as a Prop in the App component?
  2. It might make sense in larger applications, but for the sake of simplicity, I prefer to not do that.

@incerta incerta force-pushed the router-middleware branch from 85337be to 9953a74 Compare July 19, 2019 15:16
@incerta
Copy link
Contributor Author

incerta commented Jul 19, 2019

Hey @incerta
Thanks for your suggestion.
I'm trying to understand the benefits you have outlined but I fail to find one:

  1. How is that different from keeping providers in App component and just adding testStore as a Prop in the App component?
  2. It might make sense in larger applications, but for the sake of simplicity, I prefer to not do that.

I agree, this Providers abstraction approach is too specific to be presented in guideline and benefits is not obvious. I removed last commit and just add ConnectedRouter provider to App

piotrwitek
piotrwitek approved these changes Jul 19, 2019
View reviewed changes
Copy link
Owner

@piotrwitek piotrwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks now it looks great!

@piotrwitek piotrwitek merged commit f75a3cc into piotrwitek:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrwitek piotrwitek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@incerta @piotrwitek