Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorizer tests target the lambda handler and not the CLI #118

Closed
alejandrodnm opened this issue Oct 15, 2024 · 0 comments
Closed

Vectorizer tests target the lambda handler and not the CLI #118

alejandrodnm opened this issue Oct 15, 2024 · 0 comments
Labels

Comments

@alejandrodnm
Copy link
Contributor

We ported the vectorizer code from an internal repository, that tested against the lambda_handler. The tests and the lambda handler were ported as is, this enabled us to move everything without causing errors on the tests.

The way the vectorizer is exposed is via the vectorizer script and the Worker, Vectorizer classes. We need to update the tests, and decide what to do with the lambda handler.

We can move it to an examples section for vectorizer, or update the code and expose the lambda handler for people to use it.

@linear linear bot added the pgai label Oct 17, 2024
@linear linear bot closed this as completed Nov 8, 2024
@linear linear bot reopened this Nov 8, 2024
@linear linear bot reopened this Nov 14, 2024
@linear linear bot reopened this Nov 19, 2024
@linear linear bot closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant