Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it still necessary to include FeeCalculator in BlockHashQueue #34553

Open
tao-stones opened this issue Dec 20, 2023 · 0 comments
Open

Is it still necessary to include FeeCalculator in BlockHashQueue #34553

tao-stones opened this issue Dec 20, 2023 · 0 comments

Comments

@tao-stones
Copy link
Contributor

Problem

When working on a separate issue, I noticed blockhash_queue.fee_calculator.lamports_per_signature was used, but perhaps shouldn't be?

Blockhash_queue includes FeeCalculator here.

But FeeCalculator seems pretty much be replaced by FeeStructure.

Proposed Solution

can FeeCalculator be removed to reduce confusion?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tao-stones