Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The option --minimal-snapshot-download-speed is useless in 1.16.16 #33584

Open
lcgogo opened this issue Oct 8, 2023 · 1 comment
Open

The option --minimal-snapshot-download-speed is useless in 1.16.16 #33584

lcgogo opened this issue Oct 8, 2023 · 1 comment
Labels
community Community contribution

Comments

@lcgogo
Copy link

lcgogo commented Oct 8, 2023

solana-validator --version
solana-validator 1.16.16 (src:ec1115e8; feat:4033350765, client:SolanaLabs)

when I use option --minimal-snapshot-download-speed 52428800 but the solana log shows much less then the speed I given

[2023-10-08T10:39:38.255657968Z INFO  solana_download_utils] downloaded 176266352 bytes 0.4% 17721576.0 bytes/s
[2023-10-08T10:39:44.277170136Z INFO  solana_download_utils] downloaded 282690720 bytes 0.6% 17674024.0 bytes/s
[2023-10-08T10:39:50.299280043Z INFO  solana_download_utils] downloaded 389152504 bytes 0.8% 17678486.0 bytes/s
@lcgogo lcgogo added the community Community contribution label Oct 8, 2023
@steviez
Copy link
Contributor

steviez commented Dec 27, 2023

The logs you provided are not enough to determine what is happening; there are several items that come into play when attempting download:

debug!("Download progress: {download_progress:?}");
if download_progress.last_throughput < minimal_snapshot_download_speed
&& download_progress.notification_count <= 1
&& download_progress.percentage_done <= 2_f32
&& download_progress.estimated_remaining_time > 60_f32
&& *download_abort_count < maximum_snapshot_download_abort
{
if let Some(ref known_validators) = validator_config.known_validators {
if known_validators.contains(rpc_contact_info.pubkey())
&& known_validators.len() == 1
&& bootstrap_config.only_known_rpc
{
warn!(
"The snapshot download is too slow, throughput: {} < min speed {} \
bytes/sec, but will NOT abort and try a different node as it is the \
only known validator and the --only-known-rpc flag is set. \
Abort count: {}, Progress detail: {:?}",
download_progress.last_throughput,
minimal_snapshot_download_speed,
download_abort_count,
download_progress,
);
return true; // Do not abort download from the one-and-only known validator
}
}
warn!(
"The snapshot download is too slow, throughput: {} < min speed {} \
bytes/sec, will abort and try a different node. \
Abort count: {}, Progress detail: {:?}",
download_progress.last_throughput,
minimal_snapshot_download_speed,
download_abort_count,
download_progress,
);
*download_abort_count += 1;
false
} else {
true

For example, you might have already aborted several times from downloads being too slow, or you may have known validators configured such that the node you are downloading from is your ONLY option.

I'm guessing you don't have the logs around to look into this (unless you've observed the issue recently). We'd need logs and your validator startup args in order to look into it. I'll leave it open for a few days, but I'm inclined to think there was something else coming into play in your case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

No branches or pull requests

2 participants