Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Gate: on bank load account, do not try to fix up rent_epoch #28541

Open
jeffwashington opened this issue Oct 21, 2022 · 0 comments
Open
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@jeffwashington
Copy link
Contributor

Description

There was a bug that got opened when the activation of feature #26509 occurred.
On mnb, this caused 1.14 nodes to fail with a bank hash mismatch.
On testnet, all nodes were running 1.14, so the network followed the bug and defined 'correct' as updating the rent_epoch on bank load of accounts.
For mnb, the fix is to remove the code that updated the rent_epoch incorrectly. mnb and 1.14 are now happy.
For testnet, we must add a feature around the code that updates the rent_epoch on bank load of accounts. Prior to feature activation, we will update the rent_epoch. After feature activation, we will NOT update the rent_epoch.
Once the feature is activated, testnet will forevermore have the 'correct' behavior of not updating the rent_epoch on bank load of accounts.

Feature ID

CpkdQmspsaZZ8FVAouQTtTWZkc8eeQ7V3uj7dWz543rZ

Activation Method

Single Core Contributor

Minimum Beta Version

No response

Minimum Stable Version

No response

Testnet Activation Epoch

No response

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

No branches or pull requests

1 participant