Skip to content

Commit 8d59f06

Browse files
committed
Fix skeleton helper when animating
1 parent a54aa82 commit 8d59f06

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/lib/processes/load-skeleton/HandHelper.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ export class HandHelper {
6161
bone.parent.remove(bone)
6262
}
6363
})
64-
65-
console.log(`Modified hand skeleton: ${hand_type}, removed ${bones_to_remove.length} bones`)
6664
}
6765

6866
private is_hand_bone (bone_name: string): boolean {

src/script.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@ export class Bootstrap {
285285
this.process_step = ProcessStep.BindPose
286286
this.transform_controls.enabled = false // shouldn't be editing bones
287287
this.calculate_skin_weighting_for_models()
288-
// this.regenerate_skeleton_helper(this.weight_skin_step.skeleton())
289288
this.scene.add(...this.weight_skin_step.final_skinned_meshes()) // add final skinned mesh to scene
290289
this.weight_skin_step.weight_painted_mesh_group().visible = false // hide weight painted mesh
291290
this.process_step_changed(ProcessStep.AnimationsListing)
@@ -294,7 +293,9 @@ export class Bootstrap {
294293
this.process_step = ProcessStep.AnimationsListing
295294
this.animations_listing_step.begin(this.load_skeleton_step.skeleton_type(), this.load_skeleton_step.skeleton_scale())
296295

297-
this.skeleton_helper?.setJointsVisible(false)
296+
// update reference of skeleton helper to use the final skinned mesh
297+
this.regenerate_skeleton_helper(this.weight_skin_step.skeleton())
298+
this.skeleton_helper?.setJointsVisible(false) // no need to show joints during
298299

299300
// hide skeleton by default in animations listing step
300301
if (this.ui.dom_show_skeleton_checkbox !== null) {

0 commit comments

Comments
 (0)