gccrs: Fix compile_float_literal not compiling negatives properly#4287
Merged
philberty merged 1 commit intoNov 17, 2025
Merged
Conversation
gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (compile_float_literal): Add is_negative check to compile negative float literals properly. * backend/rust-compile-pattern.cc (CompilePatternCheckExpr::visit(RangePattern)): Minor optimization to E0579 checks to reduce memory copy. Signed-off-by: Yap Zhi Heng <yapzhhg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from my comment in an earlier PR: #4243 (comment)
This is a very, very subtle bug that took me quite a while to debug, I'm very surprised none of our tests were able to catch
compile_float_literalcompiling negatives wrongly.Edit for more context:
Previously, using
-1.2f32..-1.0f32as a pattern match arm throws E0579 "lower range bound must be less than upper", which is incorrect because -1.2 < -1.0. Meanwhile,-1.0f32..-1.2f32does not throw that error, which is also incorrect. This is due tocompile_float_literalnot takingis_negative()into account during code gen, so this PR aims to fix that.