Skip to content

gccrs: Fix crash in privay reporter for placeholder types#3412

Merged
philberty merged 1 commit into
masterfrom
phil/crash-3
Feb 3, 2025
Merged

gccrs: Fix crash in privay reporter for placeholder types#3412
philberty merged 1 commit into
masterfrom
phil/crash-3

Conversation

@philberty

Copy link
Copy Markdown
Member

This guards against a crash but i think this should actually be treated as if its a generic type like below. But for now this addresses a crash which can occur.

gcc/rust/ChangeLog:

* checks/errors/privacy/rust-privacy-reporter.cc (PrivacyReporter::check_base_type_privacy): Add guard for placeholder

@philberty philberty added the bug label Feb 3, 2025
@philberty philberty added this to the Remaining typecheck issues milestone Feb 3, 2025
This guards against a crash but i think this should actually be treated
as if its a generic type like below. But for now this addresses a crash which can occur.

gcc/rust/ChangeLog:

	* checks/errors/privacy/rust-privacy-reporter.cc (PrivacyReporter::check_base_type_privacy):
	Add guard for placeholder

Signed-off-by: Philip Herron <herron.philip@googlemail.com>
@philberty philberty added this pull request to the merge queue Feb 3, 2025
@philberty philberty self-assigned this Feb 3, 2025
Merged via the queue into master with commit 842c1cf Feb 3, 2025
@philberty philberty deleted the phil/crash-3 branch February 4, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant