Type check StructPatternFieldIdentPat#2174
Merged
Merged
Conversation
gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (TypeCheckPattern::visit): Type check StructPatternFieldIdentPat. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
philberty
approved these changes
Apr 28, 2023
philberty
left a comment
Member
There was a problem hiding this comment.
LGTM nice work.
Side thing to check (not related to your PR) we use a break to get out of the switch statement here but i am just wondering what would happen if we just returned early after an error if that would be safer/simpler but maybe we miss a chance to keep looking for more errors. Do you have an opinion here about the error handling.
Collaborator
Author
|
It's probably good as-is, that way we can generate both invalid field and missing field errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.