Various tokenstream fixes#2128
Merged
Merged
Conversation
Lifetime string representation used two single quotes instead of one. gcc/rust/ChangeLog: * lex/rust-token.cc (Token::as_string): Fix lifetime string representation. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
In some cases, while parsing an outer attribute, the parser would return an inner attribute. gcc/rust/ChangeLog: * parse/rust-parse-impl.h (Parser::parse_outer_attribute): Fix attribute status. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Function body were skipped in tokenstream when no return type was provided. gcc/rust/ChangeLog: * ast/rust-ast-tokenstream.cc (TokenStream::visit_function_common): Fix function body output. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
The associated type was not kept in the tokenstream. gcc/rust/ChangeLog: * ast/rust-ast-tokenstream.cc (TokenStream::visit): Keep associated type. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Qualified types had a simple colon output instead of full scope resolution tokens in QualifiedPathInTypes. gcc/rust/ChangeLog: * ast/rust-ast-tokenstream.cc (TokenStream::visit): Fix scope resolution token output. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon looking at #2122 I discovered a bug in
QualifiedPathInTypes, the scope resolution token was wrong, a colon was used instead. Whilst investigating the bug I found a few more.