Deleted the as_string AST dump

[mvvsmk]

Fixes #2022
Removed the Session::dump_ast function, and all the elements associated with it.

gcc/rust/ChangeLog:

* rust-session-manager.cc (Session::enable_dump): Removed else if (arg == "parse").
(Session::compile_crate): Removed the statement that called the dump_ast.
(Session::dump_ast): Removed dump_ast function.
* rust-session-manager.h (struct CompileOptions): Removed the PARSER_AST_DUMP option.

Signed-off-by: M V V S Manoj Kumar mvvsmanojkumar@gmail.com

Do let me know if I need to change something or missed anything .

[philberty]

You should also remove the function:

// Parses crate and dumps AST to stderr, recursively.
template <typename ManagedTokenSource>
void
Parser<ManagedTokenSource>::debug_dump_ast_output (AST::Crate &crate,
						   std::ostream &out)
{
  out << crate.as_string ();
}

From rust-parse-impl.h and it looks like clang-format is complaining

[philberty]

Ah clang-format is complaining but its unreleated to your changes do a rebase ontop of master and see if that sorts it out

[mvvsmk]

I made the changes you requested, and removed the debug_dump_ast_output function, I also had to remove the Session::dump_ast_expanded function too, and chaged the expanded dump to print only the ast_pretty. This also fixed #2021.

do tell me if I missed somthing. :)

I appologise for the large number of commits, for some reason clang format always raises an exception here, I looked at the log but still couldn't figure out what it wants it says :

--- gcc/rust/parse/rust-parse-impl.h	(original)
+++ gcc/rust/parse/rust-parse-impl.h	(reformatted)
@@ -10693,7 +10693,7 @@
     {
       lexer.skip_token ();
       alts.push_back (parse_pattern_no_alt ());
-    } 
+    }
   while (lexer.peek_token ()->get_id () == PIPE);
 
   /* alternates */

could you help me here I don't undustand what it wants me to do here
I looked at the master files:

gccrs/gcc/rust/parse/rust-parse-impl.h

Lines 10672 to 10678 in 7d38d01

	do
	{
	lexer.skip_token ();
	alts.push_back (parse_pattern_no_alt ());
	}
	while (lexer.peek_token ()->get_id () == PIPE);

and it looks the exact same T-T.

[CohenArthur]

@mvvsmk the issue is that your original code has a whitespace after the curly bracket. The clang-format removes that extra whitespace.

I would really suggest running clang-format locally for things like this, which I agree are extremely annoying to fix haha. I have my clang-format set up to run whenever I save a file in my editor and it helps a lot. So the change you have to make is this:

-<space><space><space><space>}<space>
+<space><space><space><space>}

[mvvsmk]

Thank you @CohenArthur for helping me out. I did have clang-format to run when I saved the file, but idk why it has a problem with that perticular statement, as in my IDE auto formats it again for some reason even though I didn't touch while making my changes, I'll look into it and have it properly configured.

[mvvsmk]

You should also remove the function:

// Parses crate and dumps AST to stderr, recursively.
template <typename ManagedTokenSource>
void
Parser<ManagedTokenSource>::debug_dump_ast_output (AST::Crate &crate,
						   std::ostream &out)
{
  out << crate.as_string ();
}

From rust-parse-impl.h and it looks like clang-format is complaining

@philberty I had completed the changes you requested, could you please have a look at it again, I have also rebased the PR so that github dosen't show that the PR is outdated. :) this PR should also fixes #2021 , do let me know if I missed anything .

[CohenArthur]

LGTM!

[CohenArthur]

oh, I had never realized that we were parsing the string directly here instead of doing magic in gcc/rust/lang.opt like we do for the other enums options we've added. I think this is fine but we should eventually think about moving it here maybe? but this is not relevant to your PR so no worries

[mvvsmk]

We had another file for parsing command line args?, I will check that out. :D

[mvvsmk]

update : just rebased the PR, so that it doesn't create any problems, my branch had became like 105 commits behind.